search

oclero / qlementine

⚠️🏗️ [WORK IN PROGRESS] 🍊Modern QStyle for desktop Qt6 applications.
https://oclero.github.io/qlementine/
MIT License
74 stars 16 forks source link

LineEdit password delay should be platform specific #61

Open pierrenicolasr opened 1 month ago

pierrenicolasr commented 1 month ago

Hello,

    // LineEdit
    case SH_LineEdit_PasswordCharacter:
      return QChar(0x2022).unicode(); // Bullet.
    case SH_LineEdit_PasswordMaskDelay:
      return 200;

This hard codes 200 ms delay for the password echo delay, but this is not really the wanted behavior on desktop (or non-touch screen devices) where passcodes don't have to echo typed characters.

It would be better to have a delay only when required. thanks !

oclero commented 1 month ago

Yes you're right. You can make a PR and I'll have a look

oclero commented 2 weeks ago

NB: Qlementine is an opinionated QStyle. I'm OK to set 0. I set 200 because at first I thought it looked good, but actually it's not handy on Desktop to have that feature. Let's set 0.