georgettica/make filtering more robust

[georgettica]

feat(filter): make filtering more robust

now filtering uses + and - for seperation so we can:

-name=foo
name=foo-age=bar
name=foo+age=bar

second iteration of #435 resolves #414

[georgettica]

all tests should pass, and more tests can be added to explain the new functionality

[georgettica]

Not passing and I am debugging locally.

Basically solved one issue (had a console output where it shouldn't have been) But the most I am still investigating

[georgettica]

another change I was thinking of is adding more flags to allow better flexibility:

npx ts-node examples/table.ts \
  --negation-seperator='!' \
  --addition-seperators='&' \
  --filter !name=hello&company=bob

[georgettica]

@RodEsp @mattgraham WDYT?

[RodEsp]

Hey @georgettica, sorry for the delayed response. This is another breaking change, it will prevent users from filtering based on values that contain a -. I don't think this improves the filtering ability for the table and it also doesn't make its functionality any more obvious or intuitive.

I think the correct fix for #414 is simply to add documentation or allow for using != as an operator. Anything that adds breaking changes is likely not going to get merged anytime soon.

[georgettica]

It's sad but ok. It can also be done via using alternative seperators, this way we can change the seperator if it breaks something for you

I'll create a third PR with just doc changes