search

oclif / dev-cli

MIT License
61 stars 55 forks source link

Fix tarball packing in paths with spaces #416

Closed pimterry closed 2 years ago

pimterry commented 3 years ago

Today, if the project is in a path that contains spaces, oclif-dev pack will fail (at various stages) because the raw path is passed unquoted to subcommands, which then treat either side of the space as separate arguments.

This tiny PR just wraps a few relevant arguments with quotes. This fixes this issue for me at least (building on Linux).

pimterry commented 2 years ago

@peternhale This is still an issue, and it'd be great to get this tiny fix merged.

I've just rebased. The tests are failing in the .circleci/loadgpg step, which doesn't seem to be related to these changes, I suspect there's some secrets that this PR build isn't allowed access to. Let me know if there's anything I can do to help finish this up.

peternhale commented 2 years ago

@pimterry This module is no longer active, replaced by oclif/oclif. Is it possible for you to move over to that module?

pimterry commented 2 years ago

Ok, sure. I'll migrate and open a new PR there in a minute.