search

oclif / dev-cli

MIT License
62 stars 56 forks source link

feat: optionally include path to tarball #460

Closed sumwatshade closed 2 years ago

sumwatshade commented 2 years ago

On my team, we have a use case where we are trying to build Oclif within a Bazel environment, where the previous stage has already packaged an NPM tarball. In this case, there is no need for us to rebuild the tarball during the Oclif pack command, and the attempt to do so actually results in weird NPM resolution issues. This feature proposes fixes that issue that provides a flag to input a file path, for example:

oclif-dev pack --input bazel-bin/packages/my-cli/my_cli.tgz
salesforce-cla[bot] commented 2 years ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): lshadler l***@i***.com. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

mdonnalley commented 2 years ago

@sumwatshade oclif-dev has been replaced by oclif@v2 and so we're no longer accepting PRs for this repo. However, feel free to make the same PR for oclif: https://github.com/oclif/oclif

sumwatshade commented 2 years ago

@mdonnalley sounds good, I have proposed the same changes here