search

oclif / dev-cli

MIT License
62 stars 55 forks source link

'See code' links to GitHub won't work in Typescript monorepo #470

Open JaimeObregon opened 2 years ago

JaimeObregon commented 2 years ago

This way of checking for a TypeScript repository in the readme command is fragile:

    if (plugin.pjson.devDependencies && plugin.pjson.devDependencies.typescript) {

In a TypeScript monorepo using workspaces, typescript can be defined at the root package's devDependencies, where plugin.pjson.devDependencies.typescript wont reach.

In my setup this is causing to silently miss all the links to see the source in GitHub, but this seems to be provoking #126 and #143 too.