search

ococrook / hdxstats

hdxstats: An R-package for statistical analysis of hydrogen deuterium exchange mass-spectrometry data.
Apache License 2.0
6 stars 2 forks source link

object undefined in hdxdifference function #35

Closed broncio123 closed 2 years ago

broncio123 commented 2 years ago

qDF variable is referenced in line 801 without definition via object input argument for hdxdifference function https://github.com/ococrook/hdxstats/blob/12bd49179a8875746d1221700b9f278e858dee44/R/functionalAnalysis-plots.R#L755-L851

ococrook commented 2 years ago

This should be object, thanks for spotting!

ococrook commented 2 years ago

Is this fixed in the new patch ?

broncio123 commented 2 years ago

diff <- assay(qDF)[, cols[2]] - assay(qDF)[, cols[1]]

Yes, fixed already in app_v2 branch, here https://github.com/ococrook/hdxstats/blob/77ab9c21681c9bce3c1721e9a9a5f3852dabd80a/R/functionalAnalysis-plots.R#L849

I'll close this issue as this has been fixed.