search

ocombe / ocLazyLoad

Lazy load modules & components in AngularJS
https://oclazyload.readme.io
MIT License
2.63k stars 510 forks source link

angular 1.6 compatibility #380

Closed alexan closed 7 years ago

ocombe commented 7 years ago

Hello, thanks for the PR. Just one question, does this remove compatibility with previous versions of angular ?

alexan commented 7 years ago

Thanks for the quick reply. The fixes are backwards compatible and use standard promise methods instead of deprecated .success and .error. The migration is documented here: https://docs.angularjs.org/guide/migration#-http-

ocombe commented 7 years ago

Ah perfect thanks, I'm not using angular 1 anymore, so I haven't had the opportunity to test it with 1.6

alexan commented 7 years ago

thanks for accepting. Will you push a new version to npm?

ocombe commented 7 years ago

I just released 1.1.0, I think I did it right, I haven't published a new version on this repo for ages, let me know if it works