search

ocombe / ocLazyLoad

Lazy load modules & components in AngularJS
https://oclazyload.readme.io
MIT License
2.63k stars 510 forks source link

fix(css-load): fix useCssLoadPatch determination when encountering unknown UA + platforms #417

Open booleanbetrayal opened 6 years ago

booleanbetrayal commented 6 years ago

Requires rebuild post-merge.

Fixes #416

booleanbetrayal commented 6 years ago

Wondering if you had chance to take a look at this @ocombe

booleanbetrayal commented 6 years ago

any thoughts, @ocombe ? we're seeing this fail fairly frequently with the code that's in master.

daerogami commented 6 years ago

@booleanbetrayal Did you build and test this? I'm having a similar issue, but I have no idea what tool is used to build this.

Just manually added it to the main js file and minified version. Can confirm issue is fixed; however, my ocLazyLoad was also insanely outdated on v0.6.3

booleanbetrayal commented 6 years ago

I haven't tried to build this but I could. Is that something I should do @ocombe ?

booleanbetrayal commented 6 years ago

Added dist builds to this branch @daerogami via 0b785e6

daerogami commented 6 years ago

Awesome! It will be a week or so before I can get around to testing this on the project I'm using it on. Thanks @booleanbetrayal!