ocombe / ocModal

An angularJS modal directive & service
66 stars 16 forks source link

Open Close animation #4

Closed joshua1 closed 10 years ago

joshua1 commented 10 years ago

Hi , Any Chance you could include or give pointers on how to include open close animations to this really awesome plugin. That will be the clincher i think. Thumbs up

ocombe commented 10 years ago

Hi, you can't add animations for now. But I could add this, what do you think would be the simplest way to use them:

Css styles would require more work from the users of the module, but would probably give more freedom. On the other end a parameter would mean that I'd have to define a few animations into the lib and that would be all, but it would be easier to use.

joshua1 commented 10 years ago

The plugin comes with its own style sheet ,which can have standard animation class for .ngenter and .ngleave. using animation.css (http://daneden.github.io/animate.css/) any user can change this class with the animation style they want.

ocombe commented 10 years ago

Good idea, I can always make the css styles as an addon that users can add or not and users who don't want it just use the lib as it is (loading useless stuff is not cool !). I'll get on it tomorow.

joshua1 commented 10 years ago

Right @ocombe that will be the ideal way to go. looking forward to it

ocombe commented 10 years ago

Check out the version 0.1.0 with the new animations !

joshua1 commented 10 years ago

This is nice. weldone

ocombe commented 10 years ago

I just released 0.1.1 with a small style fix :)