search

oconnor663 / blake2_simd

high-performance implementations of BLAKE2b/s/bp/sp in pure Rust with dynamic SIMD
MIT License
126 stars 22 forks source link

Adds support for blake2x by allowing max_depth 0 #12

Closed kobigurk closed 5 years ago

kobigurk commented 5 years ago

This is required to support Blake2x (https://blake2.net/blake2x.pdf).

The PR also adds testing for blake2x using the reference implementation test vectors.

oconnor663 commented 5 years ago

Thanks for this! Could you make the corresponding change on the blake2b/ side and fix+rename the tests that are failing?

kobigurk commented 5 years ago

Of course!

kobigurk commented 5 years ago

Pushed, added test vectors from the kat.

kobigurk commented 5 years ago

Thanks for all the great comments. I updated it!

oconnor663 commented 5 years ago

Absolutely, really glad to have this change and especially these tests. If you need this in production I could go ahead and tag a release?

kobigurk commented 5 years ago

Yes, I would love it to be tagged, I do want to use it in a live project :)

On Thu, Sep 5, 2019 at 8:07 PM oconnor663 notifications@github.com wrote:

Absolutely, really glad to have this change and especially these tests. If you need this in production I could go ahead and tag a release?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oconnor663/blake2_simd/pull/12?email_source=notifications&email_token=AA23MGAXKS2S77Z4BXB4FPLQIE4FFA5CNFSM4ISXBGO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD576UTY#issuecomment-528476751, or mute the thread https://github.com/notifications/unsubscribe-auth/AA23MGDE5ZSTDNSPF3UIILDQIE4FFANCNFSM4ISXBGOQ .

oconnor663 commented 5 years ago

Done! Version 0.5.8 is live.

kobigurk commented 5 years ago

Awesome! Already using it.

On Thu, Sep 5, 2019 at 9:19 PM oconnor663 notifications@github.com wrote:

Done! Version 0.5.8 is live.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oconnor663/blake2_simd/pull/12?email_source=notifications&email_token=AA23MGCUZQYKO5JPJ4WESU3QIFETNA5CNFSM4ISXBGO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AG77A#issuecomment-528510972, or mute the thread https://github.com/notifications/unsubscribe-auth/AA23MGC4LCZ6NZZ4TOJYNSLQIFETNANCNFSM4ISXBGOQ .

oconnor663 commented 5 years ago

Please send me a link to what you're building with it, if it's public.

kobigurk commented 5 years ago

Here you go: https://github.com/celo-org/bls-zexe https://github.com/celo-org/bls-zexe/pull/62

Specifically, I use the new version in: https://github.com/celo-org/bls-zexe/pull/62

On Thu, Sep 5, 2019 at 9:36 PM oconnor663 notifications@github.com wrote:

Please send me a link to what you're building with it, if it's public.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oconnor663/blake2_simd/pull/12?email_source=notifications&email_token=AA23MGGOLUESDNZDW7337KTQIFGRVA5CNFSM4ISXBGO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AITXA#issuecomment-528517596, or mute the thread https://github.com/notifications/unsubscribe-auth/AA23MGGVJG7XG6SNFKGFRZLQIFGRVANCNFSM4ISXBGOQ .