oconnor663 / blake2_simd

high-performance implementations of BLAKE2b/s/bp/sp in pure Rust with dynamic SIMD
MIT License
126 stars 22 forks source link

Bump constant_time_eq to 0.3 #29

Closed matze closed 1 year ago

matze commented 1 year ago

rust-argon2 switched already now users have two copies of constant_time_eq in their dependency tree.

oconnor663 commented 1 year ago

Thank you! Could you also add the same change in the blake2s/ subdirectory?

matze commented 1 year ago

Question is if bump of MSRV is okay or not.

oconnor663 commented 1 year ago

Yes, let's bump it in .github/workflows/ci.yml. As per the comment there, we don't really have a concrete MSRV policy, but if we did it would probably be something close to "last three stable versions". 1.66 is six/seven major versions ago, definitely no problem. Also I just pushed d9ce189cb98e00b0a0653d8a9586ff12e5774202 to master, so if you rebase on that it should get rid of the MIPS failure.

oconnor663 commented 1 year ago

Released as v1.0.2. Thanks for getting this done!

matze commented 1 year ago

Thanks for reviewing and releasing so swiftly :+1: