search

oconnor663 / blake3-py

Python bindings for the BLAKE3 cryptographic hash function
Other
139 stars 12 forks source link

c_impl: usedforsecurity=True overflows and damages max_threads #34

Closed ThomasWaldmann closed 2 years ago

ThomasWaldmann commented 2 years ago

After making it build, i thought i better run the tests (on Apple M1):

_________________________________________________________ test_usedforsecurity_ignored _________________________________________________________

    def test_usedforsecurity_ignored():
>       blake3(usedforsecurity=True)
E       ValueError: invalid value for max_threads

tests/test_blake3.py:360: ValueError
=========================================================== short test summary info ============================================================
FAILED tests/test_blake3.py::test_usedforsecurity_ignored - ValueError: invalid value for max_threads
ThomasWaldmann commented 2 years ago

What's a bit strange: the github CI did not have that failing test - why?

https://github.com/oconnor663/blake3-py/pull/32