search

oconnor663 / blake3-py

Python bindings for the BLAKE3 cryptographic hash function
Other
139 stars 12 forks source link

Update maturin version to ~=1.0 #40

Open kmichel-aiven opened 11 months ago

kmichel-aiven commented 11 months ago

This allows building blake3 with maturin 1.0, 1.1, 1.2 and future compatible versions.

The package was built and tested with each latest minor version of maturin since 0.14 (0.15.3, 1.0.1, 1.1.0 and 1.2.3) by incrementally increasing the upper bound and running :

# edit version then :
pip install --verbose --no-binary :all: . && pytest

https://www.maturin.rs/changelog

oconnor663 commented 11 months ago

Now that Maturin is post-1.0, maybe we should use a compatible version specifier like maturin~=1.2?

kmichel-aiven commented 11 months ago

Now that Maturin is post-1.0, maybe we should use a compatible version specifier like maturin~=1.2?

Good point. I've set it to ~=1.0 instead of ~=1.2 if that's ok.

That still allows compatibility with the latest but reduces the pain on Linux distribution that still package maturin 1.0 or 1.1 (Fedora 37 to 39, Debian sid). Since the build also works with these versions, no need to block them ?

kmichel-aiven commented 10 months ago

Hi, did you have time to look at this ?