oconnor663 / blake3-py

Python bindings for the BLAKE3 cryptographic hash function
Other
139 stars 12 forks source link

Fix casts in C implementation for GCC 14 #44

Closed mgorny closed 2 months ago

mgorny commented 2 months ago

Fix casts performed in the C extension module to make it build with GCC 14. This involves adding two missing casts from Blake3Object * to PyObject * for return values, and fixing casts in method definitions to use PyCFunction (i.e. the type expected by the struct) rather than PyCFunctionWithKeywords (i.e. the type that's actually used by the function, and that wouldn't require a cast in the first place).

Fixes #43

oconnor663 commented 2 months ago

Thanks! CI breaks are unrelated, fixed in 524b4992cf41ee1693de8d2010148c28b19ddd8c.

mgorny commented 2 months ago

Thanks!