search

oconnor663 / blake3-py

Python bindings for the BLAKE3 cryptographic hash function
Other
139 stars 12 forks source link

packaging build is broken by new CET code #8

Closed oconnor663 closed 4 years ago

oconnor663 commented 4 years ago

Here's what comes out of the Maturin container now:

[root@35576b33609c c]# gcc -O3 -o example example.c blake3.c blake3_dispatch.c blake3_portable.c blake3_sse41_x86-64_unix.S blake3_avx2_x86-64_unix.S blake3_avx512_x86-64_unix.S -std=c99
blake3_sse41_x86-64_unix.S:1:58: error: missing binary operator before token "("
 #if defined(__ELF__) && defined(__CET__) && __has_include(<cet.h>)
                                                          ^
blake3_avx2_x86-64_unix.S:1:58: error: missing binary operator before token "("
 #if defined(__ELF__) && defined(__CET__) && __has_include(<cet.h>)
                                                          ^
blake3_avx512_x86-64_unix.S:1:58: error: missing binary operator before token "("
 #if defined(__ELF__) && defined(__CET__) && __has_include(<cet.h>)
                                                          ^

[root@35576b33609c c]# gcc --version
gcc (GCC) 4.8.2 20140120 (Red Hat 4.8.2-15)
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
oconnor663 commented 4 years ago

The repro steps to see this failure in the context of this project are:

[host] $ docker run -it --rm -v $(pwd):/io --entrypoint bash konstin2/maturin
[root@0ca28e097b64 io]# cargo build

or just

[host] $ docker run -it --rm -v $(pwd):/io konstin2/maturin build
oconnor663 commented 4 years ago

Fix is here: https://github.com/BLAKE3-team/BLAKE3/commit/b01784a05700204789f4e2ab7bfc8f0dd8b0f35b