search

oconnor663 / duct.rs

a Rust library for running child processes
MIT License
795 stars 34 forks source link

impl IntoExecutablePath for camino paths? #90

Open sunshowers opened 3 years ago

sunshowers commented 3 years ago

Hey Jack, been a while! hope you're doing well :)

We released https://github.com/withoutboats/camino recently which adds UTF-8 path types. The readme explains the advantages of using it -- I was wondering if you think implementing IntoExecutablePath for Utf8Path and Utf8PathBuf would be reasonable (perhaps behind a feature flag).

Thanks!

oconnor663 commented 3 years ago

I only have time to write a brief comment at the moment, but I just want to say that this sounds like a good idea, and I would've been really nice to know about camino when I was writing this mess: https://github.com/BLAKE3-team/BLAKE3/blob/master/b3sum/what_does_check_do.md :)

sunshowers commented 3 years ago

Yikes! Yeah camino would really help for that, wouldn't it.

I can submit a PR for this. Would you prefer camino be

oconnor663 commented 3 years ago

Let's start with a non-default feature, if that's ok with you.