search

oconnor663 / duct.rs

a Rust library for running child processes
MIT License
795 stars 34 forks source link

add support for camino Utf8Path and Utf8PathBuf #91

Open sunshowers opened 3 years ago

sunshowers commented 3 years ago

Add support behind a non-default "camino" feature.

Closes #90.

(One question I have is whether the feature should be called camino or camino1. I personally prefer baking in the semver major version into the feature name but opinions vary.)

sunshowers commented 3 years ago

Should I also change the github config to run on PRs?

oconnor663 commented 3 years ago

Should I also change the github config to run on PRs?

Oh that's a good idea, yes please.

sunshowers commented 3 years ago

Updated! Sorry about the delay, this looks good to go now (hopefully tests pass)

oconnor663 commented 3 years ago

(Apologies, I've had a busy time at work and built up a backlog of reviews on personal projects. But I haven't forgotten about this!)

gibfahn commented 1 year ago

This is maybe obvious, but until we have this feature, the workaround is to use .as_str() on the path, e.g.:

let echo = Utf8Path::new("/bin/echo");

cmd!(echo.as_str(), "hi").run().unwrap();