oconnor663 / shared_child.rs

a wrapper around std::process::Child that lets multiple threads wait or kill at once
MIT License
39 stars 7 forks source link

Avoid using Python for simple sleep #16

Open ignatenkobrain opened 5 years ago

ignatenkobrain commented 5 years ago

https://github.com/oconnor663/shared_child.rs/blob/8ca2d654a00ac6dc58103a6c1e09d188e38271ea/src/lib.rs#L240-L244

Isn't sleep enough?

oconnor663 commented 5 years ago

These tests need to work on Windows, so just using /usr/bin/sleep won't work. It probably would be cleaner to use included Rust binaries though. Whatever we decide to do with https://github.com/oconnor663/duct.rs/issues/73 and https://github.com/oconnor663/os_pipe.rs/issues/18, we should probably replicate here.