search

ocornut / imgui

Dear ImGui: Bloat-free Graphical User interface for C++ with minimal dependencies
MIT License
59.39k stars 10.12k forks source link

Menu highlight not displayed correctly. #597

Open xDinkyx opened 8 years ago

xDinkyx commented 8 years ago

I've been implementing some up-scaled menus and I noticed that they don't seem to render properly.The highlight doesn't fill all around the item. Especially when the frame padding is increased. For instance all the way to the left side and up/down of the menu bar. imgui menubar framepadding The way it is usually drawn fills the entire menu bar around the item like so: imgui menubar correct It's a bit of a silly thing, I know, but to me it just seems incorrect.

Another (small) thing I noticed is that in DirectX the highlight is rendered one pixel too high. Only seems to be the case for DirectX applications though, not tested on other machines. imgui menubar

ocornut commented 8 years ago

Will look into it.

For that last thing with DirectX vs GL, there is a bug with the clipping rectangle settings see, https://github.com/ocornut/imgui/issues/582

xDinkyx commented 8 years ago

I only found it an issue because I am working with a big UI (for touch) and the empty space just becomes very apparent.

ocornut commented 8 years ago

Another (small) thing I noticed is that in DirectX the highlight is rendered one pixel too high.

Fixed this.

Looking into the others (it really isn't as trivial as one would expect unfortunately).

EDIT If you are working with touch perhaps it will would be better anyway to use a larger font + a bit of TouchPadding?