search

ocornut / imgui_test_engine

Dear ImGui Automation Engine & Test Suite
439 stars 52 forks source link

Define IMGUI_VIDEO_CAPTURE_ENCODER_PATH #6

Open jacobfriedman opened 1 year ago

jacobfriedman commented 1 year ago

It would be nice to have an IMGUI_VIDEO_CAPTURE_ENCODER_PATH definition included in imgui_capture_tool.h much like IMGUI_CAPTURE_DEFAULT_VIDEO_PARAMS[...]. In my world it would be conveniently sourced during ImGuiTestEngine_Postswap;

struct IMGUI_API ImGuiCaptureContext would contain char* VideoCaptureEncoderPath = IMGUI_VIDEO_CAPTURE_ENCODER_PATH or along those lines so we don't have to input it via the UI.

Thoughts?

jacobfriedman commented 1 year ago

As a sidenote, IMGUI_CAPTURE_DEFAULT_VIDEO_PARAMS_FOR_FFMPEG should probably have the suffix dropped.

ocornut commented 1 year ago

Hello,

struct IMGUI_API ImGuiCaptureContext would contain char* VideoCaptureEncoderPath = IMGUI_VIDEO_CAPTURE_ENCODER_PATH or along those lines so we don't have to input it via the UI.

If you want to change the default value or force the value, you can write to test_io.VideoCaptureEncoderPath[] ? If you ship or use a software that has an ffmpeg executable you can should setup that path yourself in the code. We don't ship ffmpeg.exe in neither Test Suite or Test Engine so it wouldn't make sense to set a default.

As a sidenote, IMGUI_CAPTURE_DEFAULT_VIDEO_PARAMS_FOR_FFMPEG should probably have the suffix dropped.

I don't understand either. They are specifically default params in the case of using FFMPEG as an encoder. We don't assume the encoder is FFMPEG but provide default params for that case.