Fixed bugs and minor optimization

ocornut / meka

MEKA - Sega 8-bit emulator with debugging/hacking tools

http://www.smspower.org/meka

302 stars 49 forks source link

Fixed bugs and minor optimization #83

Open GermanAizek opened 2 years ago

GermanAizek commented 2 years ago

@ocornut @miniupnp hi, review my PR changes and feedback me.

ocornut commented 2 years ago

Allocation failures don’t need to be checked for. There are extremely unlikely on systems we are targeting (virtual memory) and acceptable to lead to crash. I would consider other changes but not those.

GermanAizek commented 2 years ago

@ocornut, delete all pointer checks changes with allocated memory and commit other changes?

ocornut commented 2 years ago

Yes, and you can squash the commit and force-push so it becomes a single commit so I can see clearly through things. Thank you.

GermanAizek commented 2 years ago

@ocornut fix it https://github.com/ocornut/meka/pull/83/commits/1e7e0560612af4c966d80022680c5e42e9a650e5