Closed arcprabh closed 4 years ago
Review comments incorporated in https://github.com/arcprabh/ocp4-upi-powervm/pull/2
@yussufsh - pls check https://github.com/arcprabh/ocp4-upi-powervm/pull/2
@arcprabh you need to raise the PR against https://github.com/ocp-power-automation/ocp4-upi-powervm master branch. Not on your forked repo.
And please follow https://github.com/ocp-power-automation/ocp4-upi-powervm/blob/master/CONTRIBUTING.md#pull-request-process
@yussufsh
pls review https://github.com/ocp-power-automation/ocp4-upi-powervm/pull/85
Problem :
NFS disk link creation fails when the vscsi protocol is used for storage connection type for VMs in OCP 4.x cluster deployment.
GH bug reference - https://github.ibm.com/redstack-power/project-mgmt/issues/469
Analysis :
That is because the create_disk_link script is specifically checking only for multipath devices and vscsi attached disks will not be listed with that command.
The below error is seen.
TF script fails as follows:
The commands used in https://github.com/ocp-power-automation/ocp4-upi-powervm/blob/master/modules/1_bastion/templates/create_disk_link.sh is not suitable for vscsi attached devices, so we have to use another method for identifying newly attached vscsi disks.
The below existing method for identifying disks works well only for NPIV/multipath devices.
The below method works well for identifying vscsi attached disks. We need to incorporate this into the NFS disk identification and disk link method.
I have included the below changes to handle both NPIV and vSCSI attached disks to the create_disk_link.sh script.
I have tested the OCP 4.5 cluster deployment with vSCSI connection type and NFS storage class and it works fine. Check the below NFS disk attach messages from TF logs.
With this patch, for the first time, I have been able to deploy an OCP 4.5 cluster using vSCSI connection type successfully.
With this patch, I have also triggerd the script for creating another OCP 4.5 cluster with NPIV connection to ensure that the else part of the loop is getting invoked where I moved the original code after adding an if conditional check.
The NPIV deploy script is still running. Will update once done.