ocp-power-automation / ocp4-upi-powervs

OpenShift on Power Virtual Server
Apache License 2.0
23 stars 46 forks source link

Update for RHCOS image file names #495

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

This pull request updates the rhcos-table.md file

ppc64le-cloud-bot commented 1 year ago

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ppc64le-cloud-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: github-actions[bot], yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ocp-power-automation/ocp4-upi-powervs/blob/main/OWNERS)~~ [yussufsh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yussufsh commented 1 year ago

@Rajalakshmi-Girish @mkumatag the non-mergeable label is not getting removed once approved. Have noticed this before as well. Could you please help check?

Rajalakshmi-Girish commented 1 year ago

@Rajalakshmi-Girish @mkumatag the non-mergeable label is not getting removed once approved. Have noticed this before as well. Could you please help check?

Though @yussufsh seems to be the author for the commit, the PR author is shown as @github-actions[bot]. Is that expected?

While I observed the logs in prow components, I didn't see any clue on why a non-mergeable label was added.

Could it be because @github-actions[bot] is not a member of this org as comment here asks for?

yussufsh commented 1 year ago

Could it be because @github-actions[bot] is not a member of this org as comment here asks for?

That should not be an issue as this was merged before https://github.com/ocp-power-automation/ocp4-upi-powervs/pull/486 Let me try adding /ok-to-test

yussufsh commented 1 year ago

/ok-to-test

Rajalakshmi-Girish commented 1 year ago

@yussufsh maybe you need /lgtm again like in https://github.com/ocp-power-automation/ocp4-upi-powervs/pull/486#issuecomment-1636985157

mkumatag commented 1 year ago

This is the reason

image
yussufsh commented 1 year ago

This is the reason image

Where did you see it? Thanks!

mkumatag commented 1 year ago

This is the reason image

Where did you see it? Thanks!

I see this next to the merge button in the PR