search

ocpsoft / prettytime

Social Style Date and Time Formatting for Java
http://ocpsoft.org/prettytime/
Apache License 2.0
1.29k stars 253 forks source link

PrettyTimeConverter: missing annotation #216

Open flange-ipb opened 3 years ago

flange-ipb commented 3 years ago

Hi folks!

Just a tiny issue: You can annotate the PrettyTimeConverter class with @FacesConverter("prettyTimeConverter"). Without this, the example on the web page does not work.

Thanks, Frank

lincolnthree commented 3 years ago

Hey Frank!

Thanks for pointing this out. Could you give more details of where you're seeing or not seeing this info? Would love to fix it but need some more context.

Appreciated, Lincoln

The converter should be registered by the bundled faces-config.xml

tomekkup commented 1 year ago

UP ! Additionaly PrettyTimeConverter does not support Java 8 JDK DateTime API

lincolnthree commented 1 year ago

Hey @flange-ipb and @tomekkup - Thanks for the issue. Please send a test case that reproduces the issue and feel free to submit a PR/fix.