search

ocpsoft / prettytime

Social Style Date and Time Formatting for Java
http://ocpsoft.org/prettytime/
Apache License 2.0
1.29k stars 252 forks source link

Crashes on Android after 4.0.5.FINAL => 5.0.3.FINAL #231

Closed Zhuinden closed 1 year ago

Zhuinden commented 2 years ago

After updating from 4.0.5-FINAL to 5.0.3-FINAL, Resources_DE.java is missing in release variant.

Works in English, crashes in Deutsch (German).

Zhuinden commented 2 years ago

https://github.com/ocpsoft/prettytime/commit/602b3a9bb6efbc9f7032fb7307f4866227aa4135#diff-890e315590328edb1e4b44fe79ca21829fa19524a8f900da5cb8d3874f575286R1

Solution is to add Proguard rule

-keep class org.ocpsoft.prettytime.i18n.**

Because whatever is in the repo is not working

lincolnthree commented 2 years ago

Hey @Zhuinden thanks for the issue. We do have a Proguard file/rule. I'd be happy to accept a PR to fix whatever is wrong, but it appears to contain exactly what you put in your last comment so I'm not exactly sure what needs to change.

lincolnthree commented 2 years ago

Ah, actually I do see we are missing a '.' in the path. That could be the issue. Again, please feel free to test it out and send a PR if that fixes it!

lincolnthree commented 1 year ago

Closing as out of date. Please reopen if this is still an issue.