ocpsoft / prettytime

Social Style Date and Time Formatting for Java
http://ocpsoft.org/prettytime/
Apache License 2.0
1.29k stars 252 forks source link

Fix class location #246

Closed gastaldi closed 1 year ago

gastaldi commented 1 year ago
ShareASmile commented 1 year ago

@lincolnthree I think this should be merged asap, prettytime 5.0.5 tag can be deleted in the meantime and recreated after merging this patch so that prettytime 5.0.5 final which goes live on maven does contain this necessary patch. Re-release 5.0.5 requested.

lincolnthree commented 1 year ago

Dang that's an interesting one. Not sure how that got through the build process at all...

Thanks @gastaldi - you rule as always.

lincolnthree commented 1 year ago

@ShareASmile I do not believe artifacts can be removed from Maven. I will release 5.0.6

lincolnthree commented 1 year ago

Actually I never released it. Ok yes, we can still fix this version.

lincolnthree commented 1 year ago

@gastaldi How did you find this issue if I never released the JARs to central? Lol. (I'm great at this.)

gastaldi commented 1 year ago

@lincolnthree I was browsing the repo to check the impact in the core in an environment using the Jakarta APis :)

gastaldi commented 1 year ago

Somehow the parent is not in central: https://repo.maven.apache.org/maven2/org/ocpsoft/prettytime/prettytime-parent/5.0.5.Final/prettytime-parent-5.0.5.Final.pom gives 404

Looking at https://repo.maven.apache.org/maven2/org/ocpsoft/prettytime/prettytime-parent/5.0.5.Final/ I see only an .asc file was uploaded

lincolnthree commented 1 year ago

Lovely. That's the weirdest thing ever. Yeah, it got uploaded:

[INFO] [INFO] --- maven-deploy-plugin:2.8.2:deploy (default-deploy) @ prettytime-parent ---
[INFO] Uploading to ossrh: https://oss.sonatype.org/service/local/staging/deploy/maven2/org/ocpsoft/prettytime/prettytime-parent/5.0.5.Final/prettytime-parent-5.0.5.Final.pom
[INFO] Progress (1): 4.0 kB
[INFO]                     
[INFO] Uploaded to ossrh: https://oss.sonatype.org/service/local/staging/deploy/maven2/org/ocpsoft/prettytime/prettytime-parent/5.0.5.Final/prettytime-parent-5.0.5.Final.pom (4.0 kB at 1.5 kB/s)
[INFO] Downloading from ossrh: https://oss.sonatype.org/service/local/staging/deploy/maven2/org/ocpsoft/prettytime/prettytime-parent/maven-metadata.xml
[INFO] Progress (1): 331 B
[INFO]                    
[INFO] Downloaded from ossrh: https://oss.sonatype.org/service/local/staging/deploy/maven2/org/ocpsoft/prettytime/prettytime-parent/maven-metadata.xml (331 B at 2.0 kB/s)
[INFO] Uploading to ossrh: https://oss.sonatype.org/service/local/staging/deploy/maven2/org/ocpsoft/prettytime/prettytime-parent/maven-metadata.xml
[INFO] Progress (1): 368 B
[INFO]                    
[INFO] Uploaded to ossrh: https://oss.sonatype.org/service/local/staging/deploy/maven2/org/ocpsoft/prettytime/prettytime-parent/maven-metadata.xml (368 B at 771 B/s)
[INFO] Uploading to ossrh: https://oss.sonatype.org/service/local/staging/deploy/maven2/org/ocpsoft/prettytime/prettytime-parent/5.0.5.Final/prettytime-parent-5.0.5.Final.pom.asc
[INFO] Progress (1): 528 B
[INFO]                    
[INFO] Uploaded to ossrh: https://oss.sonatype.org/service/local/staging/deploy/maven2/org/ocpsoft/prettytime/prettytime-parent/5.0.5.Final/prettytime-parent-5.0.5.Final.pom.asc (528 B at 28 B/s)

I'll do a new release...