search

ocpsoft / prettytime

Social Style Date and Time Formatting for Java
http://ocpsoft.org/prettytime/
Apache License 2.0
1.29k stars 252 forks source link

Jakarta JSF integration #261

Open dstutz opened 1 year ago

dstutz commented 1 year ago

Is there any chance of publishing a version of the JSF integration built against the jakarta version the JSF API?

lincolnthree commented 1 year ago

Hey @dstutz thanks for the issue. Short answer, yes, but I don't have a ton of time at the moment. I would welcome a PR for this, which would make it much easier to put out a new version quickly. In the mean time it's fairly simple to create a converter:

You can use this as a guide, then register it using @FacesConverter or via faces-config.xml: https://github.com/ocpsoft/prettytime/blob/master/jsf/src/main/java/org/ocpsoft/prettytime/jsf/PrettyTimeConverter.java https://github.com/ocpsoft/prettytime/blob/master/jsf/src/main/resources/META-INF/faces-config.xml

Let me know if this helps?

dstutz commented 1 year ago

Yup, that is almost effortless to do on my own.

As far as a PR, again, doesn't seem like much work so I cloned the repo and I get test failures on core module (internationalization tests) attempting to build master (and 5.0.7.Final). I tried on 2 different machines:

Windows 10 - openjdk version "17.0.7" 2023-04-18 OpenJDK Runtime Environment Temurin-17.0.7+7 (build 17.0.7+7) OpenJDK 64-Bit Server VM Temurin-17.0.7+7 (build 17.0.7+7, mixed mode, sharing) Tests run: 1116, Failures: 121, Errors: 0, Skipped: 6

Gentoo Linux - openjdk version "17.0.6" 2023-01-17 OpenJDK Runtime Environment Temurin-17.0.6+10 (build 17.0.6+10) OpenJDK 64-Bit Server VM Temurin-17.0.6+10 (build 17.0.6+10, mixed mode, sharing) Tests run: 1116, Failures: 154, Errors: 0, Skipped: 6

I'm assuming I'm missing something here...

lincolnthree commented 11 months ago

Sorry for the delay. Summer stuff... That's weird. Send the PR and I'll check it out. I think JDK 8 compilation works. But something changed in 11+ that makes some of the micro-time stamps higher precision and we haven't accounted for that (the outputs of the lib are still accurate). But tests freak out.

csyperski commented 6 months ago

Has a Jakarta version been released? Everything I'm seeing still references Javax.faces.context.*

lincolnthree commented 5 months ago

Haven't gotten the PR on this yet, but would love to get this done! If someone wants to get it started and switch over all the imports. I'll try to take it over the finish line.