Forward-merge `develop` into `develop-jakartaee-9`

ocpsoft / rewrite

OCPsoft URL-Rewriting Framework

http://ocpsoft.org/rewrite/

Apache License 2.0

189 stars 86 forks source link

Forward-merge `develop` into `develop-jakartaee-9` #336

Closed larsgrefer closed 2 years ago

lincolnthree commented 2 years ago

@larsgrefer Oops, my mistake. That said I think there may also be a merge error in the pom.xml causing failures. I don't think I caused that one, but I could be wrong. I un-deleted the files I removed by mistake. The branches are all building cleanly now.

larsgrefer commented 2 years ago

Yeah, I messed up a merge here too.

Merging this was a bit tricky as there were conflicts in every pom.xml (4.0.0-SNAPSHOT vs 5.0.0-SNAPSHOT)

lincolnthree commented 2 years ago

@larsgrefer Should we be expecting this to fail on WILDFLY_REMOTE? Is this still safe to merge? Looks like deployment failures, so i'd guess it's a configuration issue for the remote container / deployed.war

larsgrefer commented 2 years ago

Wildfly has two different distributions wildfly and wildfly-preview. We need wildfly-preview for Jakarta EE 9 compatibility. It seems like WILDFLY_REMOTE used the wrong distribution.

lincolnthree commented 2 years ago

You are supremely awesome :) Thanks for confirming and taking care of the REMOTE issue.