ocramz / sparse-linear-algebra

Numerical computation in native Haskell
GNU General Public License v3.0
88 stars 10 forks source link

Fix instances #49

Closed Jaxan closed 6 years ago

Jaxan commented 6 years ago

Should fix issue #41

There were a couple of bugs in the old (commented out) instances:

I tried to keep instances (and their constraints) simple. But I think that Normed (SpVector t) could potentially be simplified. Also the I changed one constraint for the LinearVectorSpace class, because that was a bit easier.

I re-enabled many tests. All but 1 succeed.

ocramz commented 6 years ago

@Jaxan the only test that's currently failing is the complex-valued Cholesky factorization. This has really bugged me for a while, though your PR is unrelated to this. I'll try to produce a minimally-breaking example.