I'm proposing this as NFC/NFD normalization is definitely useful
for some models, and this allows users to load models which use
one of these normalizations. #257 (the proposal to use NFC by
default) didn't get enough traction to merge, but this at least allows
those of us who benefit from alternative normalization to distribute
our models to users, without having to ask them to apply a patch.
While NFKC is kept as the default, this gives the option to use NFC
and NFD normalization options. These can't be used directly, but
allow a model that has been trained with an alternative
normalization to be loaded and used. Without this patch, such a
model will throw an error when unpickling such a model.
Such a model can be built using different normalization= parameters,
as for example in #257.
I'm proposing this as NFC/NFD normalization is definitely useful for some models, and this allows users to load models which use one of these normalizations. #257 (the proposal to use NFC by default) didn't get enough traction to merge, but this at least allows those of us who benefit from alternative normalization to distribute our models to users, without having to ask them to apply a patch.
While NFKC is kept as the default, this gives the option to use NFC and NFD normalization options. These can't be used directly, but allow a model that has been trained with an alternative normalization to be loaded and used. Without this patch, such a model will throw an error when unpickling such a model.
Such a model can be built using different normalization= parameters, as for example in #257.