search

ocropus-archive / DUP-ocropy

Python-based tools for document analysis and OCR
Apache License 2.0
3.42k stars 592 forks source link

Fix arguments for function sigmoid #315

Closed stweil closed 5 years ago

stweil commented 6 years ago

Error reported by LGTM:

Call to function sigmoid with too many arguments;
should be no more than 1.

Fix it by using the same pattern as in previous calls of that function.

Signed-off-by: Stefan Weil sw@weilnetz.de

stweil commented 6 years ago

This is an untested change, so I am not sure that this is the right fix. Nor do I know whether that part of the code is used at all.

See https://lgtm.com/projects/g/tmbdev/ocropy/alerts for details.

amitdo commented 6 years ago

All the files under OLD are not being used.

stweil commented 6 years ago

Then maybe they can be removed?

amitdo commented 6 years ago

This code belongs to the 0.6 ocr engine, I don't know if this engine is functioning with the current codebase.

Apart from the 0.6 code there is a lot of garbage in 'OLD', but some useful stuff can be found there.

I suggest to ignore/blacklist 'OLD' in LGTM.

zuphilip commented 6 years ago

Then maybe they can be removed?

Maybe, some of it, other parts could be still used for inspiration to rewrite currently missing functionalities.

I suggest to ignore/blacklist 'OLD' in LGTM.

This sounds reasonable for me.