ocsf / ocsf-schema

OCSF Schema
Apache License 2.0
582 stars 118 forks source link

Added 'Windows Service Activity' event. #1103

Closed davemcatcisco closed 2 weeks ago

davemcatcisco commented 1 month ago

Related Issue:

1020

Description of changes:

This schema change introduces a new Windows Service Activity event to the Windows extension in the System Activity category. The new event extends the System Activity event only minimally:

The Windows Service object extends the pre-existing Service object in some important ways:

Because behaviour relating to Windows services is a common trigger for detections, this PR also adds the win_service attribute to the Windows Evidence Artifacts object.

davemcatcisco commented 1 month ago

A dedicated Windows event might be the way to go.

However, "services" of some form are relevant on major operating systems. Have you considered creating a more generic "Service Activity" event that isn't specific to Windows?

If such an event isn't descriptive enough then the windows extension could be used to add additional information that doesn't fit well into a generic event.

Even if the current approach is what we go with, it is good to have the reasons why written down in the pull request.

I think the reasons for having a dedicated event were already discussed elsewhere and in the issue linked to above. But...

It certainly would be possible to identify ways in which the Windows service mechanism overlaps with, say, the Linux systemd mechanism, and it would therefore be possible to define a common base event class. But would doing that actually be useful? I often feel that the result of an effort to identify a common base results is something that is vaguely satisfying intellectually but not practically useful and ultimately more trouble than it is worth. The Windows service mechanism has a very tightly defined control interface, lifecycle, and configuration which owes more to its VAX/VMS roots than to Linux.

davemcatcisco commented 1 month ago

I've been thinking a lot about this PR since discussing it at the System/Mappings call yesterday. I'm going to look at the possibiltiy of using the existing service object. Please don't spend any time reviewing this for now until I've bottomed out on that.

davemcatcisco commented 1 month ago

I've been thinking a lot about this PR since discussing it at the System/Mappings call yesterday. I'm going to look at the possibiltiy of using the existing service object. Please don't spend any time reviewing this for now until I've bottomed out on that.

I've reworked the PR so as to define a new Windows Service object which extends the pre-existing Service object. This PR is now ready for review. Marking as such.

davemcatcisco commented 1 month ago

Attn. gatekeepers (@floydtree, @pagbabian-splunk, @mikeradka, @Aniak5, @zschmerber): This PR is now ready for review. Thanks.

davemcatcisco commented 2 weeks ago

Attn. @floydtree, @pagbabian-splunk, @mikeradka, @Aniak5, @zschmerber: I still need one more approval on this PR if one of you could do the needful.

davemcatcisco commented 2 weeks ago

Attn. gatekeepers (@floydtree, @pagbabian-splunk, @mikeradka, @Aniak5, @zschmerber): This PR is now approved and ready for merge. Thanks!