search

ocsf / ocsf-schema

OCSF Schema
Apache License 2.0
617 stars 130 forks source link

General cleanup of metaschema #1167

Closed floydtree closed 1 month ago

floydtree commented 1 month ago

Related Issue: n/a

Description of changes:

  1. Sorting all event class definition files, renaming files wherever necessary (making things consistent with class_name == file_name convention)
  2. Removing includes folder to simplify reference chains in schema definition files
  3. Updating vscode metadata, metaschema files
  4. Updating contribution guide to remove references to includes dir
rmouritzen-splunk commented 1 month ago

If you've checked that the exported schema is the same before and after, then this is all good. (I suspect these kinds of changes should not affect the final "compiled" schema.)

floydtree commented 1 month ago

If you've checked that the exported schema is the same before and after, then this is all good. (I suspect these kinds of changes should not affect the final "compiled" schema.)

Yeah, these changes do not affect the complied schema.

mikeradka commented 1 month ago

The meat and potatoes look good, just wanted to check, should we mention this cleanup in the 'Misc' of CHANGELOG for good measure? Once I fire up a server from my end and verify I am comfortable with approving.