search

ocsigen / graffiti

A tiny collaborative drawing application in eliom.
http://ocsigen.org/tuto/manual/application
Other
10 stars 13 forks source link

Update Grafitti-simple to use Ojwidgets and remove o'Closure. #2

Closed abbysmal closed 10 years ago

abbysmal commented 10 years ago

This commit also fix some stuff regarding values injection, to follow the latest version of Eliom.

Since we can expect the next release of Eliom to be soon, I updated Graffiti simple (used in the tutorial) to the latest version of Eliom. I also removed O'Closure, since nobody in here really want to compile it anymore. I replaced it by a simple HTML5 slider and a custom colorpicker added in Ojwidget for the occasion.

This is a work in progress, I still need to fix some stuff and I think i'll try to split up this commit soon, but I want some feedback to be sure that I don't do something wrong here. :-)

The code needed to be a little changed, since the colorpicker is now different, I prefered to send a tuple for RGB values instead of a string, and let the client and the server do whatever they want with it.

balat commented 10 years ago

Ok this seems great :) Can I merge and install on ocsigen.org?

abbysmal commented 10 years ago

Good enough for me, but then again I don't want to cause trouble if I do something wrong. :-) This version is running here http://mirai.fr:2222 If its ok for you then merge it. I am currently rewriting the O'Closure parts in the tutorial, based on this version, I'll do a PR by the end of the week I think.

balat commented 10 years ago

Thanks :)