search

ocsigen / js_of_ocaml

Compiler from OCaml to Javascript.
http://ocsigen.org/js_of_ocaml/
Other
943 stars 185 forks source link

Fix marshalling test (compression issue was fixed in 5.1.1) #1620

Closed OlivierNicole closed 1 month ago

OlivierNicole commented 1 month ago

See https://ocaml.org/releases/5.1.1. Currently this test fails with 5.1.1.

hhugo commented 1 month ago

Why is the CI not complaining about this ?

OlivierNicole commented 1 month ago

I’m not sure; maybe its 5.1.1 compiler is configured differently from mine?

hhugo commented 1 month ago

Ah yes, I guess we could condition the test on Compression.compression_supported

hhugo commented 1 month ago

This is the only test checking compression with marshal. I'd prefer to keep it enabled on ocaml > 5.1.0 as it runs and pass in the CI. We could try to come up with a better condition to decide whether compression is enabled though.