Runtime: os_type: Cygwin -> Win32

ocsigen / js_of_ocaml

Compiler from OCaml to Javascript.

http://ocsigen.org/js_of_ocaml/

Other

952 stars 186 forks source link

Closed hhugo closed 3 months ago

hhugo commented 3 months ago

@phated, would you mind checking if this PR works for grain ? It should only affect windows.

hhugo commented 3 months ago

Cool, do you need the rest of the stubs ? I thought they were present in jsoo already.

phated commented 3 months ago

I think they are overrides related to \ path separators instead of /

hhugo commented 3 months ago

This PR now accepts both / and \. Could you try dropping your overrides with jsoo master and report if something still needs to be fixed ?

phated commented 3 months ago

I'd love to try it, but we never solved the performance problems so our test suite doesn't complete. I forget which older version we needed to pin.

hhugo commented 3 months ago

Can you try again and reopen an issue for the perf issue ?