Make the tests for uncaught exceptions more portable

ocsigen / js_of_ocaml

Compiler from OCaml to Javascript.

http://ocsigen.org/js_of_ocaml/

Other

953 stars 186 forks source link

Make the tests for uncaught exceptions more portable #1652

Closed OlivierNicole closed 2 months ago

OlivierNicole commented 2 months ago

This is part of a series of PRs intending to reduce the diff between js_of_ocaml and wasm_of_ocaml (see ocaml-wasm/wasm_of_ocaml#47).

hhugo commented 2 months ago

Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior

OlivierNicole commented 2 months ago

Sorry about that. Done

OlivierNicole commented 2 months ago

Oops, unassigned myself by mistake.

vouillon commented 2 months ago

Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior

We were only building the code, not running it, though...

hhugo commented 2 months ago

Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior

We were only building the code, not running it, though...

I'm pretty sure I've run the byte version at the time to check the behavior. I don't remember why I didn't implement a js-vs-bytecode test though

hhugo commented 2 months ago

It's

Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior

We were only building the code, not running it, though...

I'm pretty sure I've run the byte version at the time to check the behavior. I don't remember why I didn't implement a js-vs-bytecode test though

It's possible that I only ran the byte version without argument, (not calling unregister)