search

ocsigen / tyxml

Build valid HTML and SVG documents
https://ocsigen.org/tyxml/
Other
163 stars 57 forks source link

Add token list option for autocomplete attribute on inputs #303

Closed aronerben closed 2 years ago

aronerben commented 2 years ago

Implements a simplified version with enough leniency to represent the spec: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#attr-fe-autocomplete

https://github.com/ocsigen/tyxml/issues/302

aronerben commented 2 years ago

The tests are still missing and I added a question as a comment

Drup commented 2 years ago

Thanks for the PR! I agree this change is for the best, so I would be inclined to merge with a few more test (and some changelog!) It's technically a breaking change, but it's a rather benign one. :)

aronerben commented 2 years ago

Thanks for the PR! I agree this change is for the best, so I would be inclined to merge with a few more test (and some changelog!) It's technically a breaking change, but it's a rather benign one. :)

@Drup

Thanks for the review! Does the changelog suffice?

I force-pushed the branch to fix my authorship (I had forgot to set my username for this project). I added handling the case of `Tokens [], which should default to "on" in my opinion.