search

ocsigen / tyxml

Build valid HTML and SVG documents
https://ocsigen.org/tyxml/
Other
163 stars 57 forks source link

Typo whitout → without. #324

Open Mbodin opened 7 months ago

Mbodin commented 7 months ago

This looks like a typo, so I made the corresponding changes.

Given that TyXML is used in several OCaml projects and that I'm changing the type specification, there might be other checks to do before accepting this PR as-is.

Drup commented 7 months ago

Thanks ! I think I've seen that one, and didn't want to break compat for a typo :p

Next version will be a major one, since there are other changes that are needed. Can you add a change log entry ?

Mbodin commented 7 months ago

Sure! I added one under the current version, but now that I think about it, should it be made apart if you are releasing a new major version?

Drup commented 7 months ago

Yes, please create a "NEXT" section, I'll decide later what it ends up being :)