search

octabytes / FireO

Google Cloud Firestore modern and simplest convenient ORM package in Python. FireO is specifically designed for the Google's Firestore
https://fireo.octabyte.io
Apache License 2.0
247 stars 29 forks source link

Fix transaction or batch. Unlock upgrade client to 2.3.4 #145

Closed kulik0v closed 2 years ago

kulik0v commented 2 years ago

We can not write if batch any more because len is introduced in batch. https://github.com/googleapis/python-firestore/blob/main/google/cloud/firestore_v1/base_batch.py#L45-L46

We have to check explicitly is it None or not. And the same for transaction.

This fix unlock upgrade to 2.3.4.

AxeemHaider commented 2 years ago

Thanks, I will merge it, but first I have to fix the GitHub workflow for testing, I don't know why it break everytime.