Closed ADR-007 closed 1 year ago
Btw. why do we have if self.model_cls._meta.to_lowercase:
in Field
and MapField
(not just in TextField
)? Does anybody really use it? What is the use-case?
This is just because Firestore is case sensitive and I just provide and extra option to make text lowercase. So, you can easily find by text when you search. It's ok if you removed it from ListField
I think no one is using it in ListField
But I think it's good to have in TextField
This is just because Firestore is case sensitive and I just provide and extra option to make text lowercase. So, you can easily find by text when you search. It's ok if you removed it from
ListField
I think no one is using it inListField
But I think it's good to have inTextField
It still works in ListField
. The logic is in Field
class. I just removed the code duplication.
But I would expect to have this logic in TextField
only.
Yes, I think it should be only in TextField
because lowercase
property is related to string