Closed NobleUplift closed 4 years ago
It's nice that you have spent some time on this, thanks. Sorry I haven't had a chance to look at your code yet. I will try to find time at the weekend.
This all seems pretty good to me. I like the idea of using "!duke" to encode that the embezzle action requires a player not to have a duke. I agree about having a single start button. I'm not sure we really need a ui to set the maximum number of players. It could just be 10. I think instead of a game mode, you just have radio buttons to choose between inquisitor and ambassador, and a checkbox to enable teams.
couldn't find where I'd need to put the code to prevent team members from blocking foreign aid from each other
You need to add a check near throw new GameException('Cannot block your own action')
in game.js
, to make sure the person you are blocking is on a different team to you (or everyone is on the same team).
Happy New Year! Back from my vacation and back to work. I should be able to pick this back up in my free time. There's a paragraph of the rules that needs to be considered and I'll copy it here when I remember.
I'd like to make some progress on this. Are you still working on it? Or should I pick it up myself?
I like this icon for apostatize, like signing a confession: Icons: https://game-icons.net/1x1/delapouite/scroll-quill.html
And I like this one for convert, a crusader shield: https://game-icons.net/1x1/delapouite/templar-shield.html
It would be nice to show a team icon next to each player, as well as a color stripe. How about these:
https://game-icons.net/1x1/skoll/fist.html https://game-icons.net/1x1/lorc/white-tower.html
Allow players to apostatize and convert alongside coup when they have >$9
I don't see anything about this in the rules, so I think you should still be forced to coup in this case. Unless you have a convincing reason why not?
I have created a branch with your changes merged into my latest master: https://github.com/octachrome/treason/tree/coup-reformation
Please merge this into your own branch, and if you do any further work, please raise a new pull request into my coup-reformation branch, so we can work together until this is ready to ship.
I have made a lot of progress on this:
I tidied up a few other things too, such as the action names. I renamed "apostatize" to "change team" - while I think it is a cool word, it is not a familiar one, especially to people whose first language is not English.
And now we have team icons. Also, you can now challenge your teammates, since this seems to be the generally accepted interpretation of the game rules. I will make this live soon and get some feedback.
So sorry for the late reply!!! I wasn't getting GitHub notifications for this pull request. I have been getting notifications for issues... it looks like I was getting GitHub email notifications but they were being improperly/inconsistently sorted by Focused Inbox, some in Updates and some in Forums. Well, time to disable those.
Glad to see how productive you have been during the pandemic. I haven't had time to work on my GitHub projects. I think the website is down right now, but I can't wait to play 10-player Coup!
EDIT: Sorry! I just saw the very hidden "Create draft pull request" option after I created this pull request. It's really stupid that GitHub hides that functionality. I should have made this pull request a draft.
I'm creating this Pull Request with the intent that it will either linger here until I can fully implement Coup: Reformation, or if you create a coup-reformation branch, I could move my pull request to that branch instead (or if I can't update this pull request, reject it so that I can create a new one).
Long story short, I've implemented half of Coup: Reformation. I based this on the original version of Coup: Reformation which had Catholic and Protestant Teams. Here are my changes:
Not implemented yet:
Here are my thoughts on the four current issues I see with this code: