search

octachrome / treason

A clone of the card game Coup written in Node.js
Other
139 stars 79 forks source link

Substantial refactor of command logic #39

Open dnathe4th opened 4 years ago

dnathe4th commented 4 years ago

Resolves #35

octachrome commented 4 years ago

I like what you've done here. Some of my comments are nit picking, sorry about that. But hey, when you open a pull request just to improve my code, I expect perfection :)

Thanks for taking the time.

octachrome commented 4 years ago

Any progress?

dnathe4th commented 4 years ago

Yeah I'm tracking down one bug still, somewhere I'm being inconsistent on where an emission is necessary after a given command. Will try to sort it out there next few days

On Mon, May 4, 2020, 3:27 AM Chris Brown notifications@github.com wrote:

Any progress?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/octachrome/treason/pull/39#issuecomment-623384258, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKQ7SX6RTK62PM2PIBCFDRP2KCHANCNFSM4MFET36Q .