octaltree / playwright-rust

Playwright port to Rust
298 stars 31 forks source link

`ignore_http_errors` should be named `ignore_https_errors` to mirror `ignoreHTTPSErrors` #10

Closed Boscop closed 3 years ago

Boscop commented 3 years ago

https://github.com/octaltree/playwright-rust/search?q=ignoreHTTPSErrors

ignore_http_errors should be named ignore_https_errors, (because it's about HTTPS), and mirrors ignoreHTTPSErrors :)

At first I thought ignoreHTTPSErrors is not supported because I thought ignore_http_errors means something else.

octaltree commented 3 years ago

Thanks for the bug report.