search

octaltree / playwright-rust

Playwright port to Rust
316 stars 36 forks source link

press_builder() seems broken. Missing 3 default values on the builder #47

Open randall-coding opened 1 year ago

randall-coding commented 1 year ago

When I use press_builder() on my script I get this error at runtime.

Error "delay: expected number, got object"

Then I update my code to be page.press_builder().delay(30.0).press()

and then I get an error

Error "noWaitAfter: expected boolean, got object"

so then I add no_wait_after() function like so page.press_builder().no_wait_after(false).delay(30.0).press()

after that I see see this error

Error "timeout: expected number, got object"

and manually adding the timeout() to the chain makes it work.

So those three default values are not being set on my press_builder() for some reason. I'm not having this issue with any other builder so far.

DISCLAIMER: I'm not 100% sure this is true on your version. I modified my playwright slightly, but I don't think I changed anything that would effect default values for press_builder().

jquesada2016 commented 1 year ago

I noticed the same issue, but on .type_builder()