octaltree / playwright-rust

Playwright port to Rust
316 stars 36 forks source link

1.32 dev #49

Open tmahmood opened 1 year ago

tmahmood commented 1 year ago

Hey @octaltree

I have updated playwright-rust to version 1.32-beta, and all the tests are passing, and I have not faced any issues in regular usages.

Additionally, I have replaced Mutex/MutexGuard with parking_lot

Please review and merge.

Thanks :-)

d4h0 commented 1 year ago

Hi @tmahmood,

First of all, thank you so much for your work on updating playwright-rust!

I'm thinking about porting my current chromiumoxide-based code to playwright-rust, and I have a few questions (I hope it's okay that I ask them here. Issues seem to be closed on your fork).

(1) I'm wondering if you intend to continue to (help to) maintain this crate (it wouldn't make sense, to switch to playwright-rust, if it will be outdated in a few months again).

If I remember correctly, @octaltree isn't using playwright-rust anymore himself, so it's completely understandable that he doesn't want to/can't spend too much time on it.

(2) Because you probably have a good understanding now, regarding how playwright-rust works, I'm wondering if there is any chance that you'd create (more) documentation about how to update/maintain it.

I tried a few times to get playwright usable from Rust, but (because of time-constraints) I wasn't able to finish anything, yet.

(So far I've tried to update playwright-rust, to create my own bindings via Node.js or Deno, to create Wasm bindings and use playwright from Wasm executing in Node.js).

I think, with such documentation it would be much easier for other interested people (to which I count myself) to contribute to playwright-rust, and help to keep it up-to-date.

Thanks again, for your work!

tmahmood commented 1 year ago

Hey, @d4h0 ,

Glad to be of help 🙂

I can get some documentation up for upgrading. And I'll try to keep it uptodate regularly. But not sure how long I can continue

d4h0 commented 1 year ago

Thanks, @tmahmood, that sounds great!