octaltree / playwright-rust

Playwright port to Rust
316 stars 36 forks source link

Features are supposed to be additive #8

Closed nox closed 3 years ago

nox commented 3 years ago

Crate features are supposed to be additive, it should be possible to enable multiple runtimes at once.

octaltree commented 3 years ago

The selectivity runtime is taken from launchbadge/sqlx. Only one runtime can be selected in sqlx. It is possible to not include any runtime as default, as sqlx does, but tokio is the de facto standard and you should add default-features=false to use other runtimes.

octaltree commented 3 years ago

I have not read any documentation on features design. What should be avoided more, default-feature=false or must-select-to-work?