octatone / reddit.tv

HTML5 and AJAX display of videos from reddit.com to replace reddit.tv. Includes any video embed type from reddit. Only backend is reddit.com's API, everything else is clientside.
http://reddit.tv
MIT License
64 stars 72 forks source link

Title should be smaller font #9

Closed RedditTVviewer closed 13 years ago

RedditTVviewer commented 13 years ago

Reddit title is almost always longer than the space it's given. Solve this by making the font smaller, or enabling word-wrap.

octatone commented 13 years ago

reddit title's can be very very long and word wrap would cause the title section area to grow and expand randomly. The full title is available by mousing over the shortened title above the video and by mousing over the tumbnail. In opera, chrome and safari the title is ended with ellipses for a consistent look. Firefox as usual, is slow in adopting standards.

fagga commented 13 years ago

I, too, think this is an issue. It’s not like there isn’t enough space to display the full title, so, in my opinion, it shouldn’t be shortened at all.

Another way to solve this would be to put the title besides the video. I found this more convenient with the old reddit.tv, and the title could be arbitrarily long.

If the title must be above the video, maybe it could get several lines instead of just one? This wouldn’t be possible with the ellipsis, I guess, but three dots aren’t adding much anyway, compared to a complete title.

octatone commented 13 years ago

I will not push a solution that results in the title displayed on the side. It widens the layout and is not "tight" design. I'll play around with including the full title above the video, but if it is visually distracting or breaks the layout I am not going to push it. Fagga, don't send me any patches regarding this as I am actively working on it.

fagga commented 13 years ago

To me, the old reddit.tv was just as tight as the current one. But it’s your call, I’m just saying what I think.

And don’t worry, I won’t make any big layout/color changes again without asking you first. (:

octatone commented 13 years ago

Played around with the title display and with a small enough font it doess't look so bad when the title div expands. Code pushed.

fagga commented 13 years ago

That’s much better. Thanks for fixing!

Roach commented 13 years ago

Closed?

octatone commented 13 years ago

Ha, yeah :P