Dark mode: Change default text color for title/xlabel/ylabel

octave-online / octave-online-server

The infrastructure that powers Octave Online, octave-online.net

GNU Affero General Public License v3.0

318 stars 74 forks source link

Dark mode: Change default text color for title/xlabel/ylabel #27

Open Neilblaze opened 3 years ago

Neilblaze commented 3 years ago

The change theme option provides a sweet dark mode option but the text(s) need a good degree of contrast with respect to the background color as both are getting blended!

For instance, (keeping theme set to dark/brown)

title("xyz");
xlabel("anything1");
ylabel("anything2");

Returns a blended preview of the title, xlabel & ylabel. Other texts can also be kept in reference!

sffc commented 3 years ago

Thanks for the report! I've previously spent some time trying to change the default text color of the plot, but wasn't able to get it to work. I'm sure it's possible to do, either on the Octave side or the Gnuplot side.

In the mean time, you can set the text color manually using a colorspec:

title("xyz", "color", "white");

Neilblaze commented 3 years ago

Thanks for the tip @sffc :smiley: Thousands of students in my college are using octave-online not just because of this COVID pandemic but because it's very easy to use! Personally speaking, I love this project and I want to contribute to this project.

I'm from Kolkata, India & people here mostly use Bengali as their native language. I saw that this project has support for EN & ES languages. So, can I add BN in the list? :smiley:

Adding to the point, here are some improvements that can be processed.

Optimize texts for dark mode. I'm attaching a gif below.
Improving alignment the Menu section as an overflow is visible for longer emails.
Adding fullscreen option in the Menu.
Adding a home button while viewing a bucket.
Fix responsiveness issues for mobile view.

My system's default OS is Windows & I guess it won't be causing any issues to set up on my local.

sffc commented 3 years ago

Glad you find the tool useful!

If you can help provide the Bengali translations, we're happy to accept them. You can contribute translations here:

https://github.com/octave-online/oos-translations

I'll take a look at the other feature requests. You're also welcome to contribute a PR to this GitHub project if you can write the features yourself in JavaScript.

Neilblaze commented 3 years ago

Glad you find the tool useful!

Thank you :smile:

If you can help provide the Bengali translations, we're happy to accept them. You can contribute translations here:

https://github.com/octave-online/oos-translations

Sure! I'll do that :+1:

I'll take a look at the other feature requests. You're also welcome to contribute a PR to this GitHub project if you can write the features yourself in JavaScript.

Cool :100: