search

octaviospain / Musicott

JavaFX application that manages and plays music files.
http://octaviospain.github.io/Musicott
113 stars 17 forks source link

hashcode implementation #1

Closed moreaki closed 9 years ago

moreaki commented 9 years ago

Reading through your code online, I wonder if the hashcode() implementation in https://github.com/octaviospain/Musicott/blob/master/src/com/musicott/model/MusicLibrary.java#L51 should include the multiplication of the initial hash value to avoid future surprises when adding more fields. Suggestion:

hash = 73 * hash + tracks.hashCode();

octaviospain commented 9 years ago

You're right, thank you for the advise. This fix will be committed with the next release (0.7) coming soon.